Skip to content

Keep magic comments work after springifying #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Keep magic comments work after springifying #526

merged 1 commit into from
Jun 19, 2017

Conversation

sakuro
Copy link

@sakuro sakuro commented Jun 14, 2017

Currently, spgingifying by spring binstub invalidates magic comments like # frozen_string_literal: true in original binstub script if there were some.

This patch make springifying a script preserve comments after its shebang line and effectively keep magic comments work.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @grosser (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sakuro
Copy link
Author

sakuro commented Jun 15, 2017

Following Travis jobs are all failing due to the task db:test:clone has been removed since rails 5.1.

@grosser
Copy link
Collaborator

grosser commented Jun 15, 2017

so it's read on master too ?
can you make a fix-tests PR and then rebase this branch ? .. @jonleighton any ideas ? last PR from 25 days ago was green #523
... otherwise looks 👍 to me

@sakuro
Copy link
Author

sakuro commented Jun 16, 2017

I haven't dug into db:test:clone issue but I will rebase this PR if it is fixed

@jeremy
Copy link
Member

jeremy commented Jun 18, 2017

Ran into the db:test:clone issue also. #527.

The main purpose of this is to keep magic comments work.
@sakuro
Copy link
Author

sakuro commented Jun 19, 2017

Thank you @jeremy. I've rebased this PR.

@grosser grosser merged commit 85f9aa7 into rails:master Jun 19, 2017
@grosser
Copy link
Collaborator

grosser commented Jun 19, 2017

❤️

@sakuro sakuro deleted the preserve-comments-after-shebang branch July 5, 2017 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants